Upgrade to webpack 4 #20105
Closed
Upgrade to webpack 4 #20105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aparently stats.warningsFilter doesn't work correctly, so rather than blindly checking `stats.hasWarnings()` we are filtering out the warnings manually.
spalger
added
review
Team:Operations
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
|
Okay, I might have spoken too soon, I'm seeing very slow rebuild times and OOMs in rebuild... Will take another look tomorrow. |
added 5 commits
June 22, 2018 13:21
💔 Build Failed |
|
Just did a little research, our current module counts by category are: |
💔 Build Failed |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make working with code splitting and async imports easier in #16253, I've gone ahead and upgraded to webpack 4. This seems to offer a
significant advantage in build times (about 20 sec less when starting with no caches) and is working great locally. The primary changes involve the removal of theextract-text-webpack-plugin, and theCommonsChunkPlugin. The functionality of both has been preserved though, switching instead to themini-css-extract-pluginand using webpack's new built in chunking configuration.